[Mesa-dev] [PATCH 04/25] i965: Add helper functions to calculate the slice pitch of an array or 3D miptree.

[Paul Berry]

On 2 December 2013 11:39, Francisco Jerez <currojerez at riseup.net> wrote:

> ---
>  src/mesa/drivers/dri/i965/brw_tex_layout.c    | 51
> +++++++++++++++++++++------
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 10 ++++++
>  2 files changed, 50 insertions(+), 11 deletions(-)
>

Since "horizontal slice pitch" and "vertical slice pitch" are not defined
in the bspec, these funtions should have documentation explaining what they
mean.

Correct me if I'm wrong, but I think what you mean by "horizontal slice
pitch" is:

- For a 3D texture, the horizontal spacing between slices at a given
miplevel.
- For any other texture, not used.

And by "vertical slice pitch"

- For a 3D texture, the vertical spacing between each row of slices.
- For any other texture, the vertical spacing between array slices.

With additional comments added, this patch is:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20131230/17c8e5d8/attachment.html>