[Mesa-dev] [PATCH 1/4] mesa: implement GL_ARB_draw_indirect

[Christoph Bumiller]

On 02.02.2013 08:32, Adrian M Negreanu wrote:
> On Fri, Feb 1, 2013 at 11:50 PM, Christoph Bumiller
> <e0425955 at student.tuwien.ac.at> wrote:
>> I have 1 piglit test to check drawing with several combinations of
>> parameters (using transform feedback to write the commands), but
>> will make some more tests for various things like interaction with
>> PrimitiveRestart or error conditions.
>>
>> (http://people.freedesktop.org/~chrisbmr/0001-arb_draw_indirect-add-initial-test.patch)
>>
>> The gallium interface specifies a start_instance parameter that the
>> GL extension doesn't have (it's reservedMustBeZero instead, but,
>> seriously, why ? D3D does have it. Because making yet another
>> extension will be so much fun ?)
>>
>> Not sure if we want to expose this with the compatibilit profile.
>
> Hi,
>
> I have tested your changes on Android and Linux but it fails for Android.

Oops, thanks, it's a copy-paste error; next time I shall try to remember
building all drivers ...

>
> Tested the patch(es) on top of the following commits:
> ==================================================
> 6c7e95c intel: implement create image from texture
> 8e2454c intel: Account for mt->offset in intel_miptree_map
> 11f5c82 intel: Create a miptree using offsets in intel_set_texture_image_region
> 45a28a9 i965: Account for offsets when updating SURFACE_STATE.
> 163b35e intel: add pixel offset calculator for miptree levels
> 7014df0 intel: Expose intel_miptree_create_internal as
> intel_miptree_create_layout.
> f9e4e5f intel: expose dimensions and offsets of a miptree level in DRIImage
>
>
>
> Failed to build for "android""
> ================================================================================
> 6c7e95c intel: implement create image from texture
> 8e2454c intel: Account for mt->offset in intel_miptree_map
> 11f5c82 intel: Create a miptree using offsets in intel_set_texture_image_region
> 45a28a9 i965: Account for offsets when updating SURFACE_STATE.
> 163b35e intel: add pixel offset calculator for miptree levels
> 7014df0 intel: Expose intel_miptree_create_internal as
> intel_miptree_create_layout.
> f9e4e5f intel: expose dimensions and offsets of a miptree level in DRIImage
> src/mesa/drivers/dri/i965/intel_buffer_objects.c:375:46: warning:
> pointer of type 'void *' used in arithmetic [-Wpointer-arith]
> src/mesa/drivers/dri/i965/intel_fbo.c: In function 'intel_map_renderbuffer':
> src/mesa/drivers/dri/i965/intel_fbo.c:146:11: warning: pointer of type
> 'void *' used in arithmetic [-Wpointer-arith]
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c: In function
> 'intel_miptree_map_gtt':
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c:1123:58: warning:
> pointer of type 'void *' used in arithmetic [-Wpointer-arith]
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c:1136:23: warning:
> pointer of type 'void *' used in arithmetic [-Wpointer-arith]
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c:1136:41: warning:
> pointer of type 'void *' used in arithmetic [-Wpointer-arith]
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c: In function
> 'intel_miptree_unmap_etc':
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c:1344:17: warning:
> pointer of type 'void *' used in arithmetic [-Wpointer-arith]
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c:1345:17: warning:
> pointer of type 'void *' used in arithmetic [-Wpointer-arith]
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c: In function
> 'intel_miptree_alloc_mcs':
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c:305:4: warning: 'format'
> may be used uninitialized in this function [-Wuninitialized]
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c:814:14: note: 'format'
> was declared here
> src/mesa/drivers/dri/i965/intel_tex_subimage.c: In function
> 'intel_texsubimage_tiled_memcpy':
> src/mesa/drivers/dri/i965/intel_tex_subimage.c:301:29: warning:
> pointer of type 'void *' used in arithmetic [-Wpointer-arith]
> src/mesa/drivers/dri/i965/intel_tex_subimage.c:302:17: warning:
> pointer of type 'void *' used in arithmetic [-Wpointer-arith]
> src/mesa/drivers/dri/i965/intel_tex_validate.c: In function
> 'intel_tex_map_image_for_swrast':
> src/mesa/drivers/dri/i965/intel_tex_validate.c:189:73: warning:
> pointer of type 'void *' used in arithmetic [-Wpointer-arith]
> src/mesa/drivers/dri/i965/intel_tex_validate.c:190:15: warning:
> pointer of type 'void *' used in arithmetic [-Wpointer-arith]
> In file included from src/mesa/drivers/dri/i965/brw_context.c:44:0:
> src/mesa/drivers/dri/i965/brw_draw.h:45:33: error: conflicting types
> for 'tfb_vertcount'
> src/mesa/drivers/dri/i965/brw_draw.h:44:45: note: previous definition
> of 'tfb_vertcount' was here
> make: *** [out/target/product/samsungxe700t/obj/SHARED_LIBRARIES/i965_dri_intermediates/brw_context.o]
> Error 1
> FAILURE
>
>
>
> Successfully built configuration "linux", no issues
> ================================================================================
>
>
> --
> Regards!
> http://groleo.wordpress.com