[Mesa-dev] [PATCH 1/2] vbo: Print display list debug using printf() like dlist.c does.

[Jordan Justen]

On Mon, Feb 4, 2013 at 7:30 PM, Eric Anholt <eric at anholt.net> wrote:
> Jordan Justen <jljusten at gmail.com> writes:
>
>> On Fri, Feb 1, 2013 at 1:34 PM, Eric Anholt <eric at anholt.net> wrote:
>>> Otherwise, the stderr and stdout debug end up interleaved wrong
>>> when I pipe them to a file.
>>
>> Shouldn't we convert dlist.c to _mesa_debug instead? It doesn't seem
>> right for mesa to use printf...
>
> Maybe?  It's all under #if 0, so I don't care much except that it's
> consistent, and this was much easier.

dlist.c:_mesa_EndList has
  if (MESA_VERBOSE & VERBOSE_DISPLAY_LIST)
      mesa_print_display_list(ctx->ListState.CurrentList->Name);

But, I don't see _mesa_EndList being used so...

And git grep ^\\s\*printf | wc -l yields (at least) 1315 likely calls
to printf in Mesa.

I'd rather not call printf, but maybe that's a cleanup for another time...

Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

-Jordan