[Mesa-dev] [PATCH] i965: Fix Vertex URB Read Length calculation in 3DSTATE_SF on Gen6.

[Martin Steigerwald]

Am Dienstag, 5. Februar 2013 schrieb Daniel Vetter:
> On Sat, Feb 02, 2013 at 09:22:55PM +0100, Martin Steigerwald wrote:
> > Am Samstag, 2. Februar 2013 schrieb Kenneth Graunke:
> > > On 02/02/2013 04:50 AM, Martin Steigerwald wrote:
> > > > Am Samstag, 2. Februar 2013 schrieb Kenneth Graunke:
> > > >> The old calculation was off by one in certain cases.  The
> > > >> documentation contains a precise formula for how to calculate it,
> > > >> so just use that.
> > > >> 
> > > >> Fixes random corruption in Steam's Big Picture Mode, random
> > > >> corruption in PlaneShift (since the varying reordering code
> > > >> landed), and Piglit test ________.
> > > >> 
> > > >> NOTE: This is a candidate for all stable branches.
> > > >> 
> > > >> (The code needs to get cleaned up - the final result is quite ugly
> > > >> - but
> > > >> 
> > > >>   I wanted to put it on the list for the people working on these
> > > >>   bugs.)
> > > >> 
> > > >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56920
> > > >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=60172
> > > > 
> > > > Tested-by: Martin Steigerwald <martin at lichtvoll.de>
> > > > 
> > > > Works just fine on Sandybridge HD 3000 here. Glitches are gone.
> > > > 
> > > > Thanks a lot. Great turn around time from bug report to fix!
> > > > 
> > > > Will add info to bug report in a moment.
> > > > 
> > > > 
> > > > For the fun of it I have another gfx glitch for you:
> > > > 
> > > > Bug 60185 - Planeshift: Another gfx glitch with some black area
> > > > around plants https://bugs.freedesktop.org/60185
> > > > 
> > > > 
> > > > This one has been there for longer. Maybe from beginning of playing
> > > > the game.
> > > > 
> > > > 
> > > > Aside from this I have some short hang of gfx output from time to
> > > > time. I have no idea on how to provide a meaning ful bug report
> > > > about it tough, cause I have no idea what triggers the bug. Its
> > > > about 5 or 10 seconds and then everything fine again.
> > > 
> > > Crud.  When that happens, do you see any messages about 'GPU hung' in
> > > dmesg?  If I made it GPU hang, that's really bad, and means I
> > > probably didn't get this quite right yet...
> > 
> > Well its in no way proven that this related to any of your patches.
> > It can as well be an issue in mesa itself. I can try my current git
> > checkout without any of your patches to verify this.
> > 
> > About these messages: Uhm, bingo:
> > 
> > merkaba:~> zgrep -i "GPU hung" /var/log/kern.log*
> > /var/log/kern.log:Jan 29 22:29:55 merkaba kernel: [135984.784399]
> > [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
> > /var/log/kern.log:Jan 29 22:39:57 merkaba kernel: [136585.410291]
> > [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
[…]
> > /var/log/kern.log.1:Jan 27 00:51:19 merkaba kernel: [28709.417383]
> > [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
> > 
> > 
> > Nothing in older logs it seems:
> > 
> > merkaba:~> ls -l /var/log/kern.log*
> > -rw-r----- 1 root adm  478589 Feb  2 20:55 /var/log/kern.log
> > -rw-r----- 1 root adm 1318618 Jan 27 12:14 /var/log/kern.log.1
> > -rw-r----- 1 root adm   52179 Jan 20 10:49 /var/log/kern.log.2.gz
> > -rw-r----- 1 root adm   63021 Jan 13 11:18 /var/log/kern.log.3.gz
> > -rw-r----- 1 root adm   51878 Jan  6 11:12 /var/log/kern.log.4.gz
> > 
> > 
> > So all I know is that it didn´t happen with Mesa 8.0.5. I think 20th of
> > January is about the time I started to test with Mesa 9.0.2 and then
> > 9.2-devel + first your initial BLORB CopySubTexImage patch and then
> > now all four of these and your Fix Vertex URB one from this thread.
> 
> Retesting with latest 3.8-rc kernels might be good - we've just merged a
> few workaround patches for snb, which reportedly fix some hangs.
> -Daniel

I have 3.8-rc6 running. Since then I mostly see radeon drm fixes.

Any specific fix you have in mind for me to look out for?

Thanks,
-- 
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA  B82F 991B EAAC A599 84C7