[Mesa-dev] [PATCH 2/2] llvmpipe: implement dual source blending

[Brian Paul]

On 02/07/2013 08:19 PM, sroland at vmware.com wrote:
> From: Roland Scheidegger<sroland at vmware.com>
>
> link up the fs outputs and blend inputs, and make sure the second blend source
> is correctly loaded and converted (which is quite complex).
> There's a slight refactoring of the monster generate_unswizzled_blend()
> function where it makes sense to factor out alpha conversion (which needs
> to run twice for dual source blend).
> ---
>   src/gallium/drivers/llvmpipe/lp_bld_blend.h     |    1 +
>   src/gallium/drivers/llvmpipe/lp_bld_blend_aos.c |   13 +-
>   src/gallium/drivers/llvmpipe/lp_screen.c        |    2 +-
>   src/gallium/drivers/llvmpipe/lp_state_fs.c      |  331 +++++++++++++++++------
>   src/gallium/drivers/llvmpipe/lp_test_blend.c    |    3 +-
>   5 files changed, 257 insertions(+), 93 deletions(-)
>

The series LGTM, AFAICT.

So this enables the GL_ARB_blend_func_extended extension?  I think 
there's some piglit tests for that.  They pass?

Reviewed-by: Brian Paul <brianp at vmware.com>

-Brian