[Mesa-dev] [PATCH 2/5] i965: Use _NEW_POLYGON in brw_wm_state, not _NEW_POLYGONSTIPPLE.

[Ian Romanick]

On 02/07/2013 11:31 PM, Kenneth Graunke wrote:
> _NEW_POLYGONSTIPPLE covers the polygon stipple /pattern/, but the enable
> flag is covered by _NEW_POLYGON.
>
> NOTE: This is a candidate for stable branches.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>   src/mesa/drivers/dri/i965/brw_wm_state.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> Untested...my Gen4 system is not up and running these days...

That's awfully bold... to claim an untested patch is a candidate for the 
stable branch. :p

>
> diff --git a/src/mesa/drivers/dri/i965/brw_wm_state.c b/src/mesa/drivers/dri/i965/brw_wm_state.c
> index ea2dea9..e7e42b1 100644
> --- a/src/mesa/drivers/dri/i965/brw_wm_state.c
> +++ b/src/mesa/drivers/dri/i965/brw_wm_state.c
> @@ -182,10 +182,9 @@ brw_upload_wm_unit(struct brw_context *brw)
>      wm->wm5.line_aa_region_width = 0;
>      wm->wm5.line_endcap_aa_region_width = 1;
>
> -   /* _NEW_POLYGONSTIPPLE */
> +   /* _NEW_POLYGON */
>      wm->wm5.polygon_stipple = ctx->Polygon.StippleFlag;
>
> -   /* _NEW_POLYGON */
>      if (ctx->Polygon.OffsetFill) {
>         wm->wm5.depth_offset = 1;
>         /* Something wierd going on with legacy_global_depth_bias,
> @@ -234,7 +233,6 @@ brw_upload_wm_unit(struct brw_context *brw)
>   const struct brw_tracked_state brw_wm_unit = {
>      .dirty = {
>         .mesa = (_NEW_POLYGON |
> -	       _NEW_POLYGONSTIPPLE |
>   	       _NEW_LINE |
>   	       _NEW_COLOR |
>   	       _NEW_DEPTH |
>