[Mesa-dev] [PATCH v2] configure.ac: Do not error out if librt is not available.
mattst88 at gmail.com
Sat Feb 9 12:50:45 PST 2013
On Sat, Feb 9, 2013 at 12:34 PM, Vinson Lee <vlee at freedesktop.org> wrote:
> On Sat, Feb 9, 2013 at 11:38 AM, Matt Turner <mattst88 at gmail.com> wrote:
>> On Fri, Feb 8, 2013 at 7:19 PM, Vinson Lee <vlee at freedesktop.org> wrote:
>>> Some platforms, such as Mac OS X, do not have librt.
>> But Mac OS X (apparently from my quick Google search) doesn't clock_gettime.
>> clock_gettime is called from two places:
>> So this patch will just turn configure failures on platforms we do
>> care about into build failures. I don't think this is a good idea.
>> Do we care about either of these pieces of code on Mac OS X? Actually,
>> I'm curious why you're doing testing on Mac OS X at all? src/glx/apple
>> hasn't even been converted to automake.
> Would something similar to v1 of this patch be preferred? It avoided
> the clock_gettime check only for Mac OS X.
Yeah, I think that patch is okay. Sorry I missed it.
Thanks. Have an Acked-by: Matt Turner <mattst88 at gmail.com>
More information about the mesa-dev