[Mesa-dev] [PATCH V3 17/19] i965/vs: add support for ir_txf_ms on Gen6+

Eric Anholt eric at anholt.net
Tue Feb 12 10:29:14 PST 2013

Chris Forbes <chrisf at ijw.co.nz> writes:

> On Gen6, lower this to `ld` with lod=0 and an extra sample_index
> parameter.
> On Gen7, use `ld2dms`. This takes an additional MCS parameter to support
> compressed multisample surfaces, but we're not enabling them for
> multisample textures for now, so it's always ignored and can be safely
> omitted.

For these fields you're relying on to be zero in these two patches, have
you tested with loading a nonzero value into that register?  We've had
problems with that a few times -- registers often start out at zero, so
tests don't catch that kind of bug.

If you do test that, then other than minor style nits in 18/19, patches
17-19 are Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130212/41b6472f/attachment.pgp>

More information about the mesa-dev mailing list