[Mesa-dev] [PATCH] CopyTexImage: Don't check sRGB vs LINEAR for desktop GL

[Ian Romanick]

On 02/12/2013 11:35 AM, Jordan Justen wrote:
> On Mon, Feb 11, 2013 at 4:50 PM, Anuj Phogat <anuj.phogat at gmail.com> wrote:
>> On Mon, Feb 11, 2013 at 3:39 PM, Jordan Justen
>> <jordan.l.justen at intel.com> wrote:
>>>
>>> In OpenGL 4.3, new language was added that would require
>>> this check. But, if this check results in broken applications
>>> then perhaps it will be reversed.
>>>
>>> For now, remove this check and re-evaluate when
>>> desktop GL 4.3 is closer.
>>>
>> sounds good to me.
>>
>>> NOTE: This is a candidate for the 9.1 branch.
>>>
>>> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
>>> Cc: Török Edwin <edwin+ml-mesadev at etorok.net>
>>> Cc: Ian Romanick <idr at freedesktop.org>
>>
>> Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>
>
> Thanks Anuj.
>
> I also adjusted the comment to refer to GLES3 rather than GL4.3, and I
> pushed this to master and the 9.1 branch.

Did you updated the various bug reports associated with this issue?

> New comment:
> /* Page 137 (page 149 of the PDF) in section 3.8.5 of the
>   * OpenGLES 3.0.0 spec says:
>   *
>   *     "The error INVALID_OPERATION is also generated if the
>   *     value of FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING for the
>   *     framebuffer attachment corresponding to the read buffer
>   *     is LINEAR (see section 6.1.13) and internalformat is
>   *     one of the sRGB formats described in section 3.8.16, or
>   *     if the value of FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING is
>   *     SRGB and internalformat is not one of the sRGB formats."
>   */
>
> -Jordan
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>