[Mesa-dev] [PATCH 1/7] st/mesa: factor out code for determining blit.mask from CopyTexSubImage

[Brian Paul]

On 02/14/2013 07:53 AM, Marek Olšák wrote:
> I'll need this later.
> ---
>   src/mesa/state_tracker/st_cb_texture.c |  108 +++++++++++++++++++-------------
>   1 file changed, 66 insertions(+), 42 deletions(-)
>

The series looks good to me.

Regarding patch 4 (the blit-based Tex[Sub]Image change), under what 
circumstances, exactly, is the blit path used?  I'm still trying to 
figure out the code.  Basically, I'm wondering how often we're going 
to hit the blit-based path with the software drivers (llvmpipe in 
particular).  An intermediate texture blit would make things slower 
than just using the regular texstore code, as far as I see it.

Reviewed-by: Brian Paul <brianp at vmware.com>