[Mesa-dev] [Bug 61091] New: piglit glsl-fs-texture2drect regression

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Feb 18 18:00:45 PST 2013


https://bugs.freedesktop.org/show_bug.cgi?id=61091

          Priority: medium
            Bug ID: 61091
          Keywords: regression
                CC: maraeo at gmail.com
          Assignee: mesa-dev at lists.freedesktop.org
           Summary: piglit glsl-fs-texture2drect regression
          Severity: normal
    Classification: Unclassified
                OS: Linux (All)
          Reporter: vlee at freedesktop.org
          Hardware: x86-64 (AMD64)
            Status: NEW
           Version: git
         Component: Mesa core
           Product: Mesa

mesa: 07cdfdb708ac28aa487a738db30b128cb0df1dc3 (master)

$ ./bin/glsl-fs-texture2drect -auto
Probe at (37,37)
  Expected: 1.000000 0.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
PIGLIT: {'result': 'fail' }

0a1479c829ed34a65e60c6619a8164e1b079aaee is the first bad commit
commit 0a1479c829ed34a65e60c6619a8164e1b079aaee
Author: Marek Olšák <maraeo at gmail.com>
Date:   Thu Feb 14 01:03:55 2013 +0100

    st/mesa: implement blit-based TexImage and TexSubImage

    A temporary texture is created such that it matches the format and type
    combination and pixels are copied to it using memcpy. Then the blit is used
to
    copy the temporary texture to the texture image being modified by TexImage
or
    TexSubImage. The blit takes care of the format and type conversion and
    swizzling. The result is a very fast texture upload involving as little CPU
    as possible.

    This improves performance in apps which upload textures during rendering.
    An example is the Wine OpenGL backend for DirectDraw, which I used to test
    the game StarCraft. Profiling had shown that TexSubImage was taking 50% of
    CPU time without this patch, which was the main motivation for this work,
and
    now TexSubImage only takes 14% of CPU time. I had to underclock my CPU to
see
    any difference in the game and this patch does make the game a lot faster
    if the CPU is slow (or using the powersave cpufreq profile).

    Reviewed-by: Brian Paul <brianp at vmware.com>

:040000 040000 15f59d627914f821f5c58d91645e765c16dee900
9556e542ef992b9d4d1aca566b96e31e715d3999 M    src
bisect run success

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130219/d50d34a5/attachment.html>


More information about the mesa-dev mailing list