[Mesa-dev] [PATCH] radeonsi: Fix blending using destination alpha factor but non-alpha destination

[Michel Dänzer]

On Mon, 2013-02-18 at 20:11 +0100, Roland Scheidegger wrote: 
> Am 18.02.2013 19:14, schrieb Michel Dänzer:
> > From: Michel Dänzer <michel.daenzer at amd.com>
> > 
> > 11 more little piglits.
> > 
> > NOTE: This is a candidate for the 9.1 branch.
> > 
> > Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> > ---
> > 
> > Any ideas why this seems necessary with radeonsi but not with r600g?
> Maybe the hw uses an implicit 1 if the format has no alpha (though I'm
> not sure if it can always know with bgrx formats and the like).

Yeah, I can't seem to find anything like that.


> I'm wondering if there should be a helper for those fixups. Looks to me
> like quite some drivers need it (though well so far I think just
> non-gallium i965 does this plus llvmpipe, but for some of the others I'm
> skeptical if not doing it is really correct...).

Some kind of helper might be nice, maybe that could also simplify the
other blending parameters accordingly when possible.


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer