[Mesa-dev] [PATCH] radeonsi: Fix memory leak in si_shader_select.

[Michel Dänzer]

On Mit, 2013-02-20 at 08:20 +0100, Vinson Lee wrote: 
> Fixes resource leak defect reported by Coverity.
> 
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  src/gallium/drivers/radeonsi/si_state.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c
> index d20e3ff..7f76cb5 100644
> --- a/src/gallium/drivers/radeonsi/si_state.c
> +++ b/src/gallium/drivers/radeonsi/si_state.c
> @@ -1940,6 +1940,7 @@ int si_shader_select(struct pipe_context *ctx,
>  			R600_ERR("Failed to build shader variant (type=%u) %d\n",
>  				 sel->type, r);
>  			sel->current = NULL;
> +			FREE(shader);
>  			return r;
>  		}

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>

Can you fix the same problem in r600g while you're at it? :) Thanks
Vinson.


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer