[Mesa-dev] [PATCH] i965: Avoid segfault in gen6_upload_state

[Ian Romanick]

On 02/22/2013 05:15 PM, Carl Worth wrote:
> Ian Romanick <idr at freedesktop.org> writes:
>> Also, the correct way to say this is:
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59445
>
> Thanks. I missed that on this patch, but will get it right in the
> future.
>
>>> ctx->DrawBuffer->Visual doesn't know about your alpha bits when you have
>>> MRT some with alpha and some without.  I prefer the first patch, which
>>> would get my:
>>
>> That makes sense.  The probably means the other place that uses
>> ctx->DrawBuffer->Visual should get changed too.
>
> I went to make that change, but there's no loop over draw buffers in
> brw_cc.c. Presumably there's not support for MRT on that generation of
> hardware?

We've supported MRT since GEN3... so there are two bugs in that other 
code. :)

> So I think we may be fine as-is here.
>
> -Carl