[Mesa-dev] [MESA][PATCH] tgsi: fix mis-matching AOS instruction emission

[Roland Scheidegger]

Yeah the tgsi_aos emit code doesn't really get much testing, as it isn't
actually used anywhere. It might have other unnoticed bugs.

Roland

Am 27.02.2013 21:21, schrieb Jose Fonseca:
> Good catch. Thanks!
> 
> Jose
> 
> ----- Original Message -----
>> Catched this that morning
>>
>>
>> From e50374e62254e7532c695bebb3e608242638bb73 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Maxence=20Le=20Dor=C3=A9?= < maxence.ledore at gmail.com >
>> Date: Wed, 27 Feb 2013 10:24:10 +0100
>> Subject: [PATCH] tgsi: fix mis-matching instruction emission
>>
>> ---
>> src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c
>> b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c
>> index dbd9ccb..9a30cc8 100644
>> --- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c
>> +++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c
>> @@ -536,7 +536,7 @@ lp_emit_instruction_aos(
>> case TGSI_OPCODE_MIN:
>> src0 = lp_build_emit_fetch(&bld->bld_base, inst, 0, LP_CHAN_ALL);
>> src1 = lp_build_emit_fetch(&bld->bld_base, inst, 1, LP_CHAN_ALL);
>> - dst0 = lp_build_max(&bld->bld_base.base, src0, src1);
>> + dst0 = lp_build_min(&bld->bld_base.base, src0, src1);
>> break;
>> case TGSI_OPCODE_MAX:
>> --
>> 1.7.9.5
>>
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>