[Mesa-dev] [PATCH 05/10] i965: Remove brw_query_object::first_index field as it's always 0.

Eric Anholt eric at anholt.net
Thu Feb 28 09:41:42 PST 2013

Kenneth Graunke <kenneth at whitecape.org> writes:

> brw->query.index is initialized to 0 just a few lines before it's
> copied to first_index.
> Presumably the idea here was to reuse the query BO for subsequent
> queries of the same type, but since that doesn't happen, there's no need
> to have the extra code complexity.

Yeah, that was the idea.  Only, you also want to avoid keeping the old
query buffer in use for any longer after the old query had ended, or
you'll introduce extra latency on the query results.  So I'm happy to
see this garbage collected now.

(For any other reviewers trying to confirm the assertion that we don't
reuse, it's the drm_intel_bo_unreference(brw->query.bo) in

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130228/b1c7e4a9/attachment-0001.pgp>

More information about the mesa-dev mailing list