[Mesa-dev] [PATCH 02/10] build: Get rid of SRC_DIRS

[Eric Anholt]

Matt Turner <mattst88 at gmail.com> writes:
> diff --git a/configure.ac b/configure.ac
> index 9178355..f25d488 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -732,6 +732,7 @@ if test "x$enable_glx" = xyes -a \
>      enable_glx=no
>  fi
>  
> +AM_CONDITIONAL(HAVE_GLX, test "x$enable_glx" = xyes)

Looks like we'll start building src/glx for the enable_xlib_glx case,
which we shouldn't.

>  echo ""
> -if echo "$SRC_DIRS" | grep 'gallium' >/dev/null 2>&1; then
> +if test -n "x$with_gallium_drivers"; then

won't test -n always be true, because of the x?

On src/Makefile.am removal:

I'm convinced that automake doesn't actually support nonrecursive make
for non-toy projects -- the dependency tracking has major issues for
same-named files in different directories, and files moving between
directories.  As such, I don't think that incrementally moving towards
nonrecursive makes much sense -- the build performance difference is
hardly measurable, and it just makes it less obvious which Makefile.am
you should go looking in to find the build stuff you want to edit.

On the other hand, I'm so glad to see progress towards make distcheck
that I'll go along with src/Makefile.am removal. :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130228/ae0bf926/attachment.pgp>