[Mesa-dev] [PATCH] xlib: handle _mesa_initialize_visual()'s return value
brianp at vmware.com
Wed Jan 2 10:59:09 PST 2013
On 01/02/2013 11:52 AM, Ian Romanick wrote:
> On 12/26/2012 03:28 PM, Brian Paul wrote:
>> From: Brian Paul <brianp at vmware.com>
>> If the call fails, we should return NULL from XMesaCreateVisual().
>> This was found when Waffle tried to create a visual with depth/stencil
>> bits = -1. That's an illegal value for glXChooseFBConfig() and we
> Isn't -1 == GLX_DONT_CARE? If it's truly invalid, shouldn't it have
> been caught (and rejected) before this point?
Ugh. I missed GLX_DONT_CARE. It's only accepted by
glXChooseFBConfig(), not glXChooseVisual(). I can add checks for that
in the GLX code. The patch I committed is still good though.
More information about the mesa-dev