[Mesa-dev] [PATCH 00/23] GLES3 changes for readpix/teximage/FBO

[Ian Romanick]

Patches 2, 3, 4, 7, 8, 13, 22 and 23 are, as-is,

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

I still have comments coming for 15 and 17, but I need to do a bit more 
research first.

On 01/04/2013 06:41 PM, Jordan Justen wrote:
> v1:
>   * various 2101010 texture tweaks
>   * integer/signed-int/unsigned-int texture tweaks
>   * readpix/teximage/copyteximage ES3 error checks
>   * additional FBO completeness checks for GLES
>   * tested with i965+gen7
>   * crash=>pass: gles3-gtf/packed_pixels/packed_pixels
>   * crash=>pass: gles3-gtf/packed_pixels/packed_pixels_pbo
>   * crash=>pass: gles3-gtf/packed_pixels/packed_pixels_pixelstore
>   * pass=>fail: gles3-gtf/half_float/half_float_textures
>     - suspect test mismatch with spec
>   * no change: piglit/quick-driver
>
> Jordan Justen (21):
>    fbobject: don't allow LUMINANCE/INTENSITY/ALPHA fbo on GLES
>    pack: adjust clamping for int=>ubyte conversion
>    unpack: support unpacking MESA_FORMAT_ARGB2101010
>    glformats: add functions to detect signed/unsigned integer types
>    fbobject: add additional fbo completeness checks for GLES
>    glformats: add _mesa_base_format_component_count
>    copytexture: for GLES make sure integer signed vs. unsigned matches
>    framebuffer: add _mesa_get_read_renderbuffer
>    copytexture: make sure is_srgb(src) == is_srgb(dst)
>    copytexture: update error checking for GLES3
>    glformats: support _mesa_bytes_per_pixel for 2101010+GL_RGB
>    readpix: use integer conversion for RGBA/UNSIGNED_BYTE
>    readpix: add error checking for GLES3
>    readpix: raise priority of FBO completeness error
>    readpix: for implentation format/type, ignore int vs. non-int check
>    glformats: allow GL_RGB+GL_UNSIGNED_INT_2_10_10_10_REV for GLES2/3
>    i965 teximage: don't call _mesa_store_teximage if
>      format/type==GL_NONE
>    i965 teximage: allocate texture image buffer for fallback path
>    pack: handle GL_RGB+GL_UNSIGNED_INT_2_10_10_10_REV case
>    texstore argb2101010: merge GL_RGBA and GL_RGB cases
>    texformat: use MESA_FORMAT_ARGB2101010 with
>      GL_UNSIGNED_INT_2_10_10_10_REV
>
> Matt Turner (2):
>    glformats: add _mesa_es3_error_check_format_and_type
>    teximage: use _mesa_es3_error_check_format_and_type for GLES3
>
>   src/mesa/drivers/dri/intel/intel_tex_image.c |    7 +-
>   src/mesa/main/fbobject.c                     |   59 ++-
>   src/mesa/main/format_unpack.c                |   18 +
>   src/mesa/main/framebuffer.c                  |   20 +
>   src/mesa/main/framebuffer.h                  |    4 +
>   src/mesa/main/glformats.c                    |  531 +++++++++++++++++++++++++-
>   src/mesa/main/glformats.h                    |   14 +
>   src/mesa/main/pack.c                         |   14 +-
>   src/mesa/main/readpix.c                      |  105 ++++-
>   src/mesa/main/texformat.c                    |    8 +-
>   src/mesa/main/teximage.c                     |  129 +++++--
>   src/mesa/main/texstore.c                     |   21 +-
>   12 files changed, 842 insertions(+), 88 deletions(-)
>