[Mesa-dev] [PATCH 10/10] i965/fs/gen7: Emit code for GLSL 3.00 pack/unpack operations

[Ian Romanick]

On 01/10/2013 01:54 PM, Chad Versace wrote:
> On 01/10/2013 10:45 AM, Ian Romanick wrote:
>> On 01/10/2013 12:10 AM, Chad Versace wrote:
>>> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>
>>> ---
>>>    src/mesa/drivers/dri/i965/brw_defines.h            |  1 +
>>>    src/mesa/drivers/dri/i965/brw_fs.h                 |  7 ++
>>>    .../dri/i965/brw_fs_channel_expressions.cpp        | 29 +++++++-
>>>    src/mesa/drivers/dri/i965/brw_fs_emit.cpp          | 39 ++++++++++-
>>>    src/mesa/drivers/dri/i965/brw_fs_visitor.cpp       | 78 +++++++++++++++++++++-
>>>    5 files changed, 149 insertions(+), 5 deletions(-)
>
>
>>> +      if (expr->operands[i]->type->is_vector()) {
>>> +         switch (expr->operation) {
>>> +         case ir_binop_pack_half_2x16_split:
>>> +         case ir_unop_pack_half_2x16:
>>> +         case ir_unop_unpack_half_2x16:
>>> +         case ir_unop_unpack_half_2x16_split_x:
>>> +         case ir_unop_unpack_half_2x16_split_y:
>>> +            assert(!"WTF");
>>
>> Classy. :)  Maybe (like below)
>>
>>      assert("!not reached: expression operates on scalars only");
>>
>
> Um... thanks. I forgot to fix that.
> (The WTF was from a particularly frustrating debugging session).

Yeah, I figured it was something like that.  Your "WTF" is way better 
than what you usually use. :)