[Mesa-dev] [PATCH] i965/fs: Don't mix integer/float immediates in i2b handling.
eric at anholt.net
Fri Jan 11 21:09:53 PST 2013
Kenneth Graunke <kenneth at whitecape.org> writes:
> The simulator gets very angry about our i2b code:
> cmp.ne(16) g3<1>D g2<0,1,0>D 0F
> We can't mix integer DWord and float types. The only reason to use 0F
> here was to share code with f2b. Split it and use 0D instead.
My understanding is that nothing *actually* goes wrong here (the hw just
treats both things as the type of the first arg), but it seems entirely
reasonable for the simulator to warn us because usually it would be due
to us screwing up, and it'll save us some time some day when we look at
the generated code ourselves and wonder why there's a float there.
Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
More information about the mesa-dev