[Mesa-dev] [PATCH 11/11] r200: Fix probable thinko in r200EmitArrays

[Roland Scheidegger]

Oh pretty sure I wrote that bug ages ago :-).
I think you would hit it iff you'd use 12 generic vertex attributes in a 
vertex program - I guess noone ever did on that hardware...

Reviewed-by: Roland Scheidegger <sroland at vmware.com>

On 01/11/2013 06:23 PM, Johannes Obermayr wrote:
> From: Adam Jackson <ajax at redhat.com>
>
> Effectively this path would always assert.  Move the break statement to
> the (probable) intended place.
>
> Note: This is a candidate for the stable branches.
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>   src/mesa/drivers/dri/r200/r200_maos_arrays.c |    3 ++-
>   1 Datei geändert, 2 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)
>
> diff --git a/src/mesa/drivers/dri/r200/r200_maos_arrays.c b/src/mesa/drivers/dri/r200/r200_maos_arrays.c
> index 973dcaf..d7607bc 100644
> --- a/src/mesa/drivers/dri/r200/r200_maos_arrays.c
> +++ b/src/mesa/drivers/dri/r200/r200_maos_arrays.c
> @@ -166,8 +166,9 @@ void r200EmitArrays( struct gl_context *ctx, GLubyte *vimap_rev )
>   	       /* fallthrough */
>   	    case 4:
>   	       vfmt0 |= R200_VTX_W1;
> -	    break;
> +	       /* fallthrough */
>   	    }
> +	    break;
>   	 default:
>   	    assert(0);
>   	    emitsize = 0;
>