[Mesa-dev] [PATCH v2 03/18] fbobject: don't allow LUMINANCE/INTENSITY/ALPHA fbo on ES/Core

Matt Turner mattst88 at gmail.com
Sun Jan 13 00:14:02 PST 2013


On Sat, Jan 12, 2013 at 10:08 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On 01/12/2013 08:10 PM, Jordan Justen wrote:
>>
>> v2:
>>   * Only allow on GL Legacy contexts
>>
>> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
>> ---
>>   src/mesa/main/fbobject.c |    3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
>> index c2be3ff..a219398 100644
>> --- a/src/mesa/main/fbobject.c
>> +++ b/src/mesa/main/fbobject.c
>> @@ -511,7 +511,8 @@ _mesa_is_legal_color_format(const struct gl_context
>> *ctx, GLenum baseFormat)
>>      case GL_LUMINANCE_ALPHA:
>>      case GL_INTENSITY:
>>      case GL_ALPHA:
>> -      return ctx->Extensions.ARB_framebuffer_object;
>> +      return ctx->API == API_OPENGL_COMPAT &&
>> +             ctx->Extensions.ARB_framebuffer_object;
>>      case GL_RED:
>>      case GL_RG:
>>         return ctx->Extensions.ARB_texture_rg;
>
>
> Could we get a spec citation for this?  I sure see a lot of references to
> these formats in the ES 3.0 spec, and it isn't immediately clear to me that
> they're gone.  (Though, they should be, and I definitely hope they are!)

Appendix F (OpenGL ES 2.0 Compatibility) actually lists luminance,
alpha, and luminance alpha formats as being available but discouraged
and likely to be removed in a future version, so they're still in ES
3.0.


More information about the mesa-dev mailing list