[Mesa-dev] [PATCH 3/4] llvmpipe: more fixes for integer color buffers

[Roland Scheidegger]

On 01/14/2013 09:50 AM, Brian Paul wrote:
> On 01/12/2013 05:29 PM, sroland at vmware.com wrote:
>> From: Roland Scheidegger<sroland at vmware.com>
>>
>> Cast back the fake floats to ints, and make sure we don't try to do
>> scaling
>> in format conversion (which only makes sense with normalized values).
>> Also need to disable blending and alpha test (as per spec) for such
>> buffers.
>> This makes fbo-blending from the piglit ext_texture_integer tests work
>> for most
>> formats (some crash, and the luminance and intensity variants have the
>> GB or
>> GBA channels respectively wrong).
>
> The code looks OK, but I wonder if it should be the state tracker's
> responsibility to disable blending and alpha test when using integer
> color buffers?

I was wondering about that as well (in fact it took me a long time to 
figure out why the test didn't work as I thought for some reason the 
state tracker would already do this) but I think the reason it's not 
done is that the blend state is independent of the actual bound 
renderbuffers.

Roland