[Mesa-dev] [PATCH v2 00/18] GLES3 changes for readpix/teximage/FBO

[Ian Romanick]

Patches 1 through 7, 9, 12, 13, and 14 are

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

I think Eric is probably right about 8.  The rest I want to review a bit 
more in context.

Maybe push 1 through 7 sooner than the others?

On 01/12/2013 08:10 PM, Jordan Justen wrote:
> v2:
>   * Note that I am still relying on patch NAK'ed by idr to pass gles3-gtf
>     - [18/18] fbobject: add additional fbo completeness checks for GLES
>   * Six reviewed patches were pushed to master
>   * Fix various v1 concerns:
>     - Drop changes related to int vs. non-int readpix
>     - Drop changes to i965 TexImage
>     - Drop int=>ubyte clamp change
>   * Implementation format/type: updated to return format/type
>     that better matches the current color read buffer
>     - [17/18] framebuffer: update allowed implementation format/type
>   * Fix patch partitioning issue with teximage (rb_internal_format
>     variable declared in patch after first usage.)
>   * _mesa_get_read_renderbuffer => _mesa_get_read_renderbuffer_for_format
>
> v1:
>   * various 2101010 texture tweaks
>   * integer/signed-int/unsigned-int texture tweaks
>   * readpix/teximage/copyteximage ES3 error checks
>   * additional FBO completeness checks for GLES
>   * tested with i965+gen7
>   * crash=>pass: gles3-gtf/packed_pixels/packed_pixels
>   * crash=>pass: gles3-gtf/packed_pixels/packed_pixels_pbo
>   * crash=>pass: gles3-gtf/packed_pixels/packed_pixels_pixelstore
>   * pass=>fail: gles3-gtf/half_float/half_float_textures
>     - suspect test mismatch with spec
>   * no change: piglit/quick-driver
>
> Jordan Justen (16):
>    fbobject: add VERBOSE=api message for check framebuffer status
>    fbobject: add VERBOSE=api message for renderbuffer storage
>    fbobject: don't allow LUMINANCE/INTENSITY/ALPHA fbo on ES/Core
>    framebuffer: add _mesa_get_read_renderbuffer
>    copyteximage: update signed vs. unsigned format matching
>    copyteximage: make sure is_srgb(src) == is_srgb(dst)
>    copyteximage: Use Driver's AllocTextureImageBuffer instead of
>      TexImage
>    copyteximage: update error checking for GLES3
>    readpix: add error checking for GLES3
>    glformats: allow GL_RGB+GL_UNSIGNED_INT_2_10_10_10_REV for GLES2/3
>    pack: handle GL_RGB+GL_UNSIGNED_INT_2_10_10_10_REV case
>    readpix: check FBO completeness before trying to access the
>      read-buffer
>    extensions: enable EXT_color_buffer_float for ES2/ES3
>    readpix: allow implementation format/type
>    framebuffer: update allowed implementation format/type
>    fbobject: add additional fbo completeness checks for GLES
>
> Matt Turner (2):
>    glformats: add _mesa_es3_error_check_format_and_type
>    teximage: use _mesa_es3_error_check_format_and_type for GLES3
>
>   src/mesa/main/extensions.c  |    1 +
>   src/mesa/main/fbobject.c    |   96 ++++++++--
>   src/mesa/main/framebuffer.c |   47 ++++-
>   src/mesa/main/framebuffer.h |    5 +
>   src/mesa/main/glformats.c   |  447 +++++++++++++++++++++++++++++++++++++++++++
>   src/mesa/main/glformats.h   |    5 +
>   src/mesa/main/pack.c        |   12 +-
>   src/mesa/main/readpix.c     |   83 +++++++-
>   src/mesa/main/teximage.c    |  125 ++++++++++--
>   9 files changed, 777 insertions(+), 44 deletions(-)
>