[Mesa-dev] [PATCH V4 2/6] intel: create a miptree for a region based on an offset, size, and level.

[Eric Anholt]

Abdiel Janulgue <abdiel.janulgue at linux.intel.com> writes:
> diff --git a/src/mesa/drivers/dri/intel/intel_regions.h b/src/mesa/drivers/dri/intel/intel_regions.h
> index 8737a6d..bb0ccef 100644
> --- a/src/mesa/drivers/dri/intel/intel_regions.h
> +++ b/src/mesa/drivers/dri/intel/intel_regions.h
> @@ -174,6 +174,14 @@ struct __DRIimageRec {
>     uint32_t offsets[3];
>     struct intel_image_format *planar_format;
>  
> +   /* particular miptree level */
> +   GLuint width;
> +   GLuint height;
> +   GLuint level_x;
> +   GLuint level_y;
> +   GLuint slice_x_offset;
> +   GLuint slice_y_offset;

This doesn't belong in this patch, since these new fields aren't used
here.

I also don't think we need a level/slice differentiation.  These images
are a single rectangle, so just one x/y offset to the image should be
sufficient, which would be the sum of level/slice offset on the creating
side.

> +
>     void *data;
>  };
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130115/3bbc6b35/attachment.pgp>