[Mesa-dev] [PATCH] radeon/r200: Fix FBO formats

[Milan Kostić]

 No, no regress in piglit i've seen at all, only better... i even
played whole Drawn 2 game:
 http://www.drawngame.com/games/dark-flight
under wine in OpenGL mode, it works perfectly now, needs culling under
fbo which is fixed now and this fix to display text and so works
exactly the same as with nvidia on Windows.

 It can further pass 2 more test in piglit if those are ported from intel:

 fbo-nodepth-test
 http://cgit.freedesktop.org/mesa/mesa/commit/?id=4d4f2daefabdc4ca1dd778a9265475c65ef52936

 i've tried that one and it pass and maybe this for fbo-cubemap - but
not tried:

 http://cgit.freedesktop.org/mesa/mesa/commit/?id=80513ec8b4c812b9c6249cc5824337a5f04ab34c

 Now i checked supertuxkart game, it has some problems with alpha in
XRGB8888 format. Under non-fbo mode kart model have black background,
and under fbo models are transparent. I fixed it for non fbo case with
R200_TXFORMAT_ALPHA_IN_MAP for XRGB8888 also in r200_blit, but don't
know where is this format controled for fbos?  I mentoioned this
because text is slightly transparent also in that Drawn game, it only
works with with fbo extension in opengl mode, i guess that needs the
same fix for XRGB8888 format to expect alpha under fbo, etc... But OK
that can be another bug :).

2013/1/16, Marek Olšák <maraeo at gmail.com>:
> On Tue, Jan 15, 2013 at 7:15 PM, Alex Deucher <alexdeucher at gmail.com>
> wrote:
>> On Fri, Jan 11, 2013 at 6:37 AM, smoki <smoki00790 at gmail.com> wrote:
>>> Piglit passes more fbo tests on rv280, 14/28 before and now 28/33.
>>> Also should fix bug:
>>> https://bugs.freedesktop.org/show_bug.cgi?id=27704
>>
>> Does this regress anything in piglit?  It's been a while since I
>> looked at this code, I think the issue may be that r1xx/r2xx asics
>> only support ARGB render buffers while the texture hardware supports
>> both ARGB and RGBA formats so you may run into cases where you can
>> texture from a buffer, but can't render to it, at least not without an
>> intermediate blit to convert the format first.
>
> In r300g, I decided to only support RGBA and BGRA formats and not ARGB
> and ABGR because of a lack of blending support. Maybe we should do the
> same for r1xx/r2xx to make things simpler.
>
> Marek
>