[Mesa-dev] [PATCH 6/9] extensions: enable EXT_color_buffer_float for ES3

Matt Turner mattst88 at gmail.com
Fri Jan 18 16:26:15 PST 2013


On Fri, Jan 18, 2013 at 4:16 PM, Ian Romanick <idr at freedesktop.org> wrote:
> On 01/18/2013 03:55 PM, Matt Turner wrote:
>>
>> From: Jordan Justen <jordan.l.justen at intel.com>
>>
>> [mattst88] v2: Enable only for ES3 per spec.
>>
>> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
>> ---
>>   src/mesa/main/extensions.c |  1 +
>>   src/mesa/main/fbobject.c   | 26 +++++++++++++++++---------
>>   src/mesa/main/readpix.c    |  2 ++
>>   3 files changed, 20 insertions(+), 9 deletions(-)
>>
>> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
>> index 1867e5a..39f83d7 100644
>> --- a/src/mesa/main/extensions.c
>> +++ b/src/mesa/main/extensions.c
>> @@ -233,6 +233,7 @@ static const struct extension extension_table[] = {
>>      { "GL_EXT_unpack_subimage",                     o(dummy_true),
>> ES2, 2011 },
>>      { "GL_EXT_vertex_array_bgra",
>> o(EXT_vertex_array_bgra),                   GL,             2008 },
>>      { "GL_EXT_vertex_array",                        o(dummy_true),
>> GLL,            1995 },
>> +   { "GL_EXT_color_buffer_float",                  o(dummy_true),
>> ES3, 2013 },
>>
>>      /* OES extensions */
>>      { "GL_OES_blend_equation_separate",
>> o(EXT_blend_equation_separate),                  ES1,       2009 },
>> diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
>> index 9db5035..b2b6ec5 100644
>> --- a/src/mesa/main/fbobject.c
>> +++ b/src/mesa/main/fbobject.c
>> @@ -1217,21 +1217,27 @@ _mesa_base_fbo_format(struct gl_context *ctx,
>> GLenum internalFormat)
>>                ctx->Extensions.ARB_framebuffer_object ? GL_ALPHA : 0;
>>      case GL_R16F:
>>      case GL_R32F:
>> -      return (_mesa_is_desktop_gl(ctx) &&
>> -             ctx->Extensions.ARB_texture_rg &&
>> -             ctx->Extensions.ARB_texture_float) ? GL_RED : 0;
>> +      return ((_mesa_is_desktop_gl(ctx) &&
>> +               ctx->Extensions.ARB_texture_rg &&
>> +               ctx->Extensions.ARB_texture_float) ||
>> +              (ctx->API == API_OPENGLES2) /* EXT_color_buffer_float */ )
>
>
> _mesa_is_gles3(ctx)?

Oh, right. Fixed.


More information about the mesa-dev mailing list