[Mesa-dev] [PATCH] scons: Fix dependencies of generated headers.

Brian Paul brianp at vmware.com
Mon Jan 21 10:55:56 PST 2013


On 01/21/2013 10:57 AM, jfonseca at vmware.com wrote:
> From: José Fonseca<jfonseca at vmware.com>
>
> It appears that scons implicit dependency scanners fail to chain
> dependencies of generated headers when these are outside the build tree.
>
> This patch ensures generated source files are _always_ put in the build
> tree. I'm not 100% this will fix all depency issues, but from my
> experiments it does seem to fix this.
>
> NOTE: For this to be effective it is necessary to clean the source tree
> from generated header/source files.
> ---
>   src/gallium/state_trackers/vega/SConscript |    6 ++--
>   src/gallium/targets/libgl-xlib/SConscript  |    4 +--
>   src/glx/SConscript                         |    9 ++----
>   src/mapi/glapi/SConscript                  |    4 +--
>   src/mapi/glapi/gen/SConscript              |   46 ++++++++++++----------------
>   src/mapi/vgapi/SConscript                  |    5 +--
>   src/mesa/SConscript                        |   23 ++------------
>   src/mesa/drivers/osmesa/SConscript         |    3 +-
>   src/mesa/drivers/x11/SConscript            |    4 +--
>   9 files changed, 34 insertions(+), 70 deletions(-)

Looks good AFAICT.  Thanks!

Reviewed-by: Brian Paul <brianp at vmware.com>


More information about the mesa-dev mailing list