[Mesa-dev] [PATCH RFC v1] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

[Paul Berry]

On 20 January 2013 14:15, Paul Berry <stereotype441 at gmail.com> wrote:

> On 19 January 2013 11:06, Kenneth Graunke <kenneth at whitecape.org> wrote:
>
>> +   /* CopyTexSubImage should happen even in conditional rendering.  We
>> could
>> +    * turn it off and back on again.  For now, just bail instead.
>> +    */
>> +   if (ctx->Query.CondRenderQuery)
>> +      return false;
>>
>
> This shouldn't be necessary.  Blorp ignores any 3D pipeline state that the
> client has set up (including conditional rendering state), so if you just
> drop this check, the copy should happen just fine even if conditional
> rendering is on.
>

Related question: did you happen to notice this?
https://cvs.khronos.org/bugzilla/show_bug.cgi?id=9562#c1.  (Short story for
those who don't have khronos access: glBlitFramebuffer is supposed to be
conditionalized.)  I'm betting Mesa doesn't get this right.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130121/3f625937/attachment.html>