[Mesa-dev] [PATCH 02/32] mesa: Track the packing mode of a UBO in gl_uniform_buffer
cworth at cworth.org
Wed Jan 23 09:28:09 PST 2013
Ian Romanick <idr at freedesktop.org> writes:
> From: Ian Romanick <ian.d.romanick at intel.com>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
I really prefer not to see commits with only the single-line summary for
a commit message.
The single-line summary is perfect for describing "what" the patch
does. And the above is a great example.
The rest of the commit message should describe "why" the patch is doing
what it does. And whenever it's missing, I'm left wondering.
Here, for example, you start tracking the packing mode. But nothing is
actually using the tracked information. I can guess that you are laying
the groundwork for something later. But the commit message should say
that and tell me what it is. That can help a lot for patch review.
It could even be something really short such as:
We'll need this later for the Frobbenheim pass.
And similar for later patches in the series.
-Carl (who might be stepping on some toes, culturally-speaking)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
More information about the mesa-dev