[Mesa-dev] [PATCH 03/32] linker: Refactor intra-stage block compatabililty testing

[Carl Worth]

Ian Romanick <idr at freedesktop.org> writes:
> +bool
> +link_uniform_blocks_are_compatible(const gl_uniform_block *a,
> +				   const gl_uniform_block *b)
> +{
> +   assert(strcmp(a->Name, b->Name) == 0);
...
> +      if (strcmp(old_block->Name, new_block->Name) == 0)
> +	 return link_uniform_blocks_are_compatible(old_block, new_block)
> +	    ? i : -1;

Moving the strcmp to the body of the function, (it's there
already---just need to replace the assert with "if(strcmp(a,b)) return
false;"), would give a less fragile interface here.

With that:

Reviewed-by: Carl Worth <cworth at cworth.org>

-Carl

-- 
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130123/1cd6e9f4/attachment.pgp>