[Mesa-dev] [PATCH 20/32] glsl: Recurs into uniform blocks just like uniform structures

Carl Worth cworth at cworth.org
Wed Jan 23 10:32:15 PST 2013


Ian Romanick <idr at freedesktop.org> writes:
> From: Ian Romanick <ian.d.romanick at intel.com>

Misspelled "recurse" as "recurs" above.

-Carl

PS. While I'm here, the missing "why part" of the commit message here
might simply be:

	The only difference is how to access the name.

This is one of the cases where there's not really much rationale to
explain, but I still think the discipline of always putting something
into this part of the commit message is worthwhile. (In this case, that
simple text would have saved me opening up the file to look at the
existing code to see why there wasn't more code sharing here.)

-- 
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130123/e0225c5d/attachment.pgp>


More information about the mesa-dev mailing list