[Mesa-dev] [PATCH 16/32] glsl: Modify uniform_field_visitor::visit_field to take a row_major parameter

[Ian Romanick]

On 01/23/2013 01:19 PM, Carl Worth wrote:
> Ian Romanick <idr at freedesktop.org> writes:
>> @@ -454,7 +460,6 @@ link_update_uniform_buffer_variables(struct gl_shader *shader)
>>   	 for (unsigned j = 0; j < shader->UniformBlocks[i].NumUniforms; j++) {
>>   	    if (!strcmp(var->name, shader->UniformBlocks[i].Uniforms[j].Name)) {
>>   	       found = true;
>> -	       var->uniform_block = i;
>>   	       var->location = j;
>>   	       break;
>>   	    }
>
> This hunk looks like it's supposed to belong in a different commit.

Yes.  Good catch.  This part of the patch clean up happened at about 
3am, so I wasn't at my best. :(

> -Carl
>