[Mesa-dev] [PATCH (gles3) 15/20] glsl: Add lowering pass for GLSL ES 3.00 pack/unpack operations (v2)

Ian Romanick idr at freedesktop.org
Wed Jan 23 12:53:08 PST 2013


On 01/23/2013 03:48 PM, Chad Versace wrote:
> On 01/23/2013 06:06 AM, Ian Romanick wrote:
>> On 01/22/2013 10:36 PM, Matt Turner wrote:
>>> On Mon, Jan 21, 2013 at 12:49 AM, Chad Versace
>>> <chad.versace at linux.intel.com> wrote:
>>>> +   /**
>>>> +    * \brief Lower a packSnorm2x16 expression.
>>>> +    *
>>>> +    * \param vec2_rval is packSnorm2x16's input
>>>> +    * \return packSnorm2x16's output as a uint rvalue
>>>> +    */
>>>> +   ir_rvalue*
>>>> +   lower_pack_snorm_2x16(ir_rvalue *vec2_rval)
>>>> +   {
>>>> +      /* From page 88 (94 of pdf) of the GLSL ES 3.00 spec:
>>>> +       *
>>>> +       *    hihgp uint packSnorm2x16(vec2 v)
>>>
>>> high.
>>
>> No, highp is correct.
>
> I think Matt was pointing out that the "high" in "highp" was misspelled.

Yes... which I missed both times I read the original code.  My bad.



More information about the mesa-dev mailing list