[Mesa-dev] [PATCH 1/4] i965: Also examine _BaseFormat when deciding to perform xRGB_alpha fixups

Carl Worth cworth at cworth.org
Wed Jan 23 13:37:24 PST 2013


Eric Anholt <eric at anholt.net> writes:
> I think the _mesa_get_format_bits could just be dropped -- we shouldn't
> have ALPHA_BITS==0 unless the baseformat has no alpha.

Good point. I did have the same thought after the fact.

> Patches 3 and 4 are:
>
> Reviewed-by: Eric Anholt <eric at anholt.net>

Thanks. I'll change patch 1 as suggested above.

I'll also look closer at the texture_integer_glsl130 test
result. Otherwise, I think this series is ready.

-Carl

-- 
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130123/b4cb6ebd/attachment.pgp>


More information about the mesa-dev mailing list