[Mesa-dev] [PATCH] i965/disasm: Fix horizontal stride of dest registers

[Eric Anholt]

Chad Versace <chad.versace at linux.intel.com> writes:

> The bug: The printed horizontal stride was the numerical value of the
>   BRW_HORIZONTAL_$N enum.
> The fix: Translate the enum before printing.
>
> Note: This is a candidate for the stable releases.
> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>

> @@ -537,8 +539,8 @@ static int dest (FILE *file, struct brw_instruction *inst)
>  					reg_type_size[inst->bits1.ia1.dest_reg_type]);
>  	    if (inst->bits1.ia1.dest_indirect_offset)
>  		format (file, " %d", inst->bits1.ia1.dest_indirect_offset);
> -	    string (file, "]");
> -	    format (file, "<%d>", inst->bits1.ia1.dest_horiz_stride);
> +	    string (file, "]<");
> +	    err |= control (file, "horiz stride", horiz_stride, inst->bits1.ia1.dest_horiz_stride, NULL);

missing the '<' printout?

Other than that,
Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130123/dfe3fe5e/attachment.pgp>