[Mesa-dev] [PATCH] i965: Use GL_RED for DEPTH_TEXTURE_MODE in ES 3.0 for unsized formats.

[Eric Anholt]

Kenneth Graunke <kenneth at whitecape.org> writes:

> On 01/23/2013 10:28 PM, Ian Romanick wrote:
>> On 01/23/2013 06:27 PM, Kenneth Graunke wrote:
>>> Khronos has apparently decided that depth textures with sized formats
>>> (allowed with ARB_internalformat_query or ES 3.0) should be treated as
>>> GL_RED, while unsized formats (an existing feature) should be treated
>>> as GL_INTENSITY for compatibility with ES 2.0.
>>>
>>> Ian is proposing changes to ARB_internalformat_query which will make
>>> this actually legal and consistent.
>>>
>>> A similar problem exists with GL 4.2, but we're going to ignore that
>>> for the time being.
>>>
>>> Tested on Ivybridge: no Piglit regressions; fixes 4 es3conform tests:
>>> - depth_texture_fbo
>>> - depth_texture_fbo_clear
>>> - depth_texture_teximage
>>> - depth_texture_texsubimage
>>>
>>> Cc: Ian Romanick <idr at freedesktop.org>
>>
>> We probably could have done this in core Mesa, but I think this is okay
>> for now.  I pushed a version of this patch with my R-b to the gles3 branch.
>
> Yeah, I was going to make a core Mesa helper function until I realized 
> it was so little code.

Except it's yet more code in our drawing path, when we could initialize
it once at teximage time, right?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130124/649d594d/attachment-0001.pgp>