[Mesa-dev] [PATCH] mesa: implement GL_ARB_texture_buffer_range v5

Eric Anholt eric at anholt.net
Sat Jan 26 15:58:57 PST 2013


Christoph Bumiller <e0425955 at student.tuwien.ac.at> writes:
> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
> index 31a559e..e71f6e1 100644
> --- a/src/mesa/main/teximage.c
> +++ b/src/mesa/main/teximage.c

> +/** GL_ARB_texture_buffer_object */
> +void GLAPIENTRY
> +_mesa_TexBuffer(GLenum target, GLenum internalFormat, GLuint buffer)
> +{
> +   struct gl_buffer_object *bufObj;
> +
> +   GET_CURRENT_CONTEXT(ctx);
> +
> +   if (!ctx->Extensions.ARB_texture_buffer_object) {
> +      _mesa_error(ctx, GL_INVALID_OPERATION, "glTexBuffer");
> +      return;
> +   }

The check for also ctx->API == API_OPENGL_CORE here has been dropped, so
I think the i965 driver would start accepting this function in compat
contexts when it shouldn't.

If that check gets re-added, this is
Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130126/c9b8040a/attachment.pgp>


More information about the mesa-dev mailing list