[Mesa-dev] [PATCH] android: use gralloc_drm_get_gem_handle api

Chad Versace chad.versace at linux.intel.com
Mon Jan 28 12:55:16 PST 2013

On 01/23/2013 11:56 PM, Tapani Pälli wrote:
> currently a gralloc internal structure is exposed to mesa,
> use a query function instead to maintain ABI compatibility.
> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> ---
>  src/egl/drivers/dri2/platform_android.c                   |  8 ++------
>  src/egl/main/Android.mk                                   |  4 +++-
>  src/gallium/state_trackers/egl/android/native_android.cpp | 10 ++--------
>  3 files changed, 7 insertions(+), 15 deletions(-)

Thanks, committed to master.

I quickly looked through the drm_gralloc repo, and see a lot of opportunity
for cleanups. In the headers, there is no indication of which interfaces are
private to drm_gralloc and which are exported to consumers. I bet the original
authors didn't consider that issue.

Anyway, just an observation on another potential gralloc improvement.

More information about the mesa-dev mailing list