[Mesa-dev] [PATCH] i965: Fix assignment instead of comparison in asserts.

Chad Versace chad.versace at linux.intel.com
Mon Jan 28 13:52:04 PST 2013


Committed. Thanks for fixing my bug :)

On 01/25/2013 11:27 PM, Vinson Lee wrote:
> Fixes side effect in assertion defects reported by Coverity.
> 
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  src/mesa/drivers/dri/i965/brw_fs_emit.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_emit.cpp b/src/mesa/drivers/dri/i965/brw_fs_emit.cpp
> index d9ed27c..45072da 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_emit.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_emit.cpp
> @@ -951,8 +951,8 @@ fs_generator::generate_pack_half_2x16_split(fs_inst *inst,
>  {
>     assert(intel->gen >= 7);
>     assert(dst.type == BRW_REGISTER_TYPE_UD);
> -   assert(x.type = BRW_REGISTER_TYPE_F);
> -   assert(y.type = BRW_REGISTER_TYPE_F);
> +   assert(x.type == BRW_REGISTER_TYPE_F);
> +   assert(y.type == BRW_REGISTER_TYPE_F);
>  
>     /* From the Ivybridge PRM, Vol4, Part3, Section 6.27 f32to16:
>      *
> 



More information about the mesa-dev mailing list