[Mesa-dev] [PATCH v2] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

Carl Worth cworth at cworth.org
Mon Jan 28 16:41:06 PST 2013

Kenneth Graunke <kenneth at whitecape.org> writes:
> Previously, BLORP only handled BlitFramebuffer.  This patch adds an
> additional frontend for doing CopyTexSubImage.  It also makes it the
> default.

Reading through the patch, it looks like there are two independent
things happening here---extending blorp to support a copytexsubimage
operation and then preferring to use that first ti implement
CopyTexSubImage for i965.

And sure enough your commit message has "also" in it, (and even "and"
in the one-line summary).

I recommend splitting this into two commits.

> No Piglit regressions on Ivybridge.  I have not tested Sandybridge.

I just tested on Sandybridge---no piglit regressions.

Reviewed-by: Carl Worth <cworth at cworth.org>


carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130129/0758126c/attachment.pgp>

More information about the mesa-dev mailing list