[Mesa-dev] [PATCH 2/2] intel: initialize fs_visitor::params_remap in constructor

Ian Romanick idr at freedesktop.org
Mon Jan 28 18:52:40 PST 2013


On 01/28/2013 05:06 PM, Frank Henigman wrote:
> Set fs_visitor::params_remap to NULL in the constructor.
> This variable was potentially tested in fs_visitor::remove_dead_constants()
> before being set.
>
> Signed-off-by: Frank Henigman <fjhenigman at google.com>

This patch is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

Also, please add the following to the commit message:

NOTE: This is a candidate for stable release branches.

> ---
>   src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> index d4f6fc9..86141a6 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> @@ -2342,6 +2342,8 @@ fs_visitor::fs_visitor(struct brw_context *brw,
>      this->virtual_grf_use = NULL;
>      this->live_intervals_valid = false;
>
> +   this->params_remap = NULL;
> +
>      this->force_uncompressed_stack = 0;
>      this->force_sechalf_stack = 0;
>
>



More information about the mesa-dev mailing list