[Mesa-dev] [PATCH 2/2] st/mesa: only enable GL_EXT_framebuffer_multisample if GL_MAX_SAMPLES >= 2

[Jose Fonseca]

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>

That said, I think that we should eventually have an option to fake multisample (advertise without actually doing it) not only most software renderers don't support it (and can't advertise GL 3.x without it) but also because even when they do support it, performance will suck big time...

Jose

----- Original Message -----
> We never really have multisampling with one sample per pixel.
> See also http://bugs.freedesktop.org/show_bug.cgi?id=59873
> 
> Note: This is a candidate for the 9.0 branch.
> ---
>  src/mesa/state_tracker/st_extensions.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/src/mesa/state_tracker/st_extensions.c
> b/src/mesa/state_tracker/st_extensions.c
> index f0d8a4c..34c0d7b 100644
> --- a/src/mesa/state_tracker/st_extensions.c
> +++ b/src/mesa/state_tracker/st_extensions.c
> @@ -534,7 +534,6 @@ void st_init_extensions(struct st_context *st)
>     ctx->Extensions.EXT_blend_minmax = GL_TRUE;
>     ctx->Extensions.EXT_framebuffer_blit = GL_TRUE;
>     ctx->Extensions.EXT_framebuffer_object = GL_TRUE;
> -   ctx->Extensions.EXT_framebuffer_multisample = GL_TRUE;
>     ctx->Extensions.EXT_fog_coord = GL_TRUE;
>     ctx->Extensions.EXT_gpu_program_parameters = GL_TRUE;
>     ctx->Extensions.EXT_pixel_buffer_object = GL_TRUE;
> @@ -657,6 +656,9 @@ void st_init_extensions(struct st_context *st)
>        /* one sample doesn't really make sense */
>        ctx->Const.MaxSamples = 0;
>     }
> +   else if (ctx->Const.MaxSamples >= 2) {
> +      ctx->Extensions.EXT_framebuffer_multisample = GL_TRUE;
> +   }
>  
>     if (ctx->Const.MaxDualSourceDrawBuffers > 0)
>        ctx->Extensions.ARB_blend_func_extended = GL_TRUE;
> --
> 1.7.3.4
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>