[Mesa-dev] [PATCH 04/14] glsl: Add a comment to note what an exec_list is a list of.

Chad Versace chad.versace at linux.intel.com
Mon Jul 1 10:41:46 PDT 2013


On 06/29/2013 07:43 PM, Matt Turner wrote:
> ---
>   src/glsl/ast.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/glsl/ast.h b/src/glsl/ast.h
> index df2a21f..af7fcd9 100644
> --- a/src/glsl/ast.h
> +++ b/src/glsl/ast.h
> @@ -526,6 +526,7 @@ public:
>   			  struct _mesa_glsl_parse_state *state);
>
>      ast_fully_specified_type *type;
> +   /* List of ast_declaration * */
                                  ^^^^

This start-start confused me. I was lucky and untangled the
meaning, the next person might not have luck untangling.

Please quote the type to distinguish between star1 and star2,
like /* List of 'ast_declaration*' */

With such a clarification,
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

>      exec_list declarations;
>
>      /**
>



More information about the mesa-dev mailing list