[Mesa-dev] [PATCH 11/14] i965: Remove render_target_supported from the vtable.

Chad Versace chad.versace at linux.intel.com
Tue Jul 2 16:47:18 PDT 2013


On 07/02/2013 01:54 AM, Kenneth Graunke wrote:
> brw_render_target_supported() is the only implementation of this
> function, so it makes sense to just call it directly.
>
> Rather than adding an #include of brw_wm.h, this patch moves the
> prototype to brw_context.h.  Prototypes seem to be in rather arbitrary
> places at the moment, and either place seems as good as the other.

I agree. The prototype situation is a mess. But that problem's root cause
seems to be a lack of well-defined interfaces between modules, which is
not easily fixed. So, yeah, let's gather the scattered prototypes into
one location until a better approach becomes apparent.

Patches 10-11 are
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>   src/mesa/drivers/dri/i965/brw_context.h   | 2 ++
>   src/mesa/drivers/dri/i965/brw_vtbl.c      | 1 -
>   src/mesa/drivers/dri/i965/brw_wm.h        | 2 --
>   src/mesa/drivers/dri/i965/intel_context.h | 2 --
>   src/mesa/drivers/dri/i965/intel_fbo.c     | 2 +-



More information about the mesa-dev mailing list