[Mesa-dev] [PATCH] gallivm: Eliminate redundant lp_build_select calls.

[Roland Scheidegger]

Am 05.07.2013 15:22, schrieb jfonseca at vmware.com:
> From: José Fonseca <jfonseca at vmware.com>
> 
> lp_build_cmp already returns 0 / ~0, so the lp_build_select call is
> unnecessary.
> 
> Trivial.
> ---
>  src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c
> index 1feaa19..af523b1 100644
> --- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c
> +++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c
> @@ -1161,14 +1161,9 @@ iset_emit_cpu(
>     struct lp_build_emit_data * emit_data,
>     unsigned pipe_func)
>  {
> -   LLVMValueRef nz = lp_build_const_vec(bld_base->base.gallivm,
> -					bld_base->int_bld.type, ~0U);
>     LLVMValueRef cond = lp_build_cmp(&bld_base->int_bld, pipe_func,
>                                      emit_data->args[0], emit_data->args[1]);
> -   emit_data->output[emit_data->chan] = lp_build_select(&bld_base->int_bld,
> -                                          cond,
> -                                          nz,
> -                                          bld_base->int_bld.zero);
> +   emit_data->output[emit_data->chan] = cond;
>  }
>  
>  /* TGSI_OPCODE_IMAX (CPU Only) */
> @@ -1620,14 +1615,9 @@ uset_emit_cpu(
>     struct lp_build_emit_data * emit_data,
>     unsigned pipe_func)
>  {
> -   LLVMValueRef nz = lp_build_const_vec(bld_base->base.gallivm,
> -					bld_base->uint_bld.type, ~0U);
>     LLVMValueRef cond = lp_build_cmp(&bld_base->uint_bld, pipe_func,
>                                      emit_data->args[0], emit_data->args[1]);
> -   emit_data->output[emit_data->chan] = lp_build_select(&bld_base->uint_bld,
> -                                          cond,
> -					  nz,
> -                                          bld_base->uint_bld.zero);
> +   emit_data->output[emit_data->chan] = cond;
>  }
>  
>  
> 

Reviewed-by: Roland Scheidegger <sroland at vmware.com>