[Mesa-dev] R600/SI: Support for local memory and derivatives

Michel Dänzer michel at daenzer.net
Wed Jul 10 09:24:44 PDT 2013


On Mit, 2013-07-10 at 08:15 -0700, Tom Stellard wrote:
> On Wed, Jul 10, 2013 at 12:32:25PM +0200, Michel Dänzer wrote:
> > On Fre, 2013-06-28 at 14:37 -0700, Tom Stellard wrote:
> > > On Wed, Jun 19, 2013 at 06:28:21PM +0200, Michel Dänzer wrote:
> > > > 
> > > > These patches implement enough of local memory support to allow radeonsi
> > > > to use that for computing derivatives, as suggested by Tom.
> > > > 
> > > > They also almost allow test/CodeGen/R600/local-memory.ll to generate
> > > > code for SI. Right now it still fails because it tries to copy a VGPR to
> > > > an SGPR, which is not possible.
> > > 
> > > Can you add some lit tests for these new intrinsics
> > 
> > Done, updated patches attached.
> > 
> > 
> > > and also add CHECK lines for SI to the existing local-memory.ll test.
> > 
> > Can't do that while it still fails to generate SI code. Should I commit
> > the other patches anyway, which are only necessary for that test?
> 
> Can you add a TODO comment to that test for adding SI checks?
> 
> With that change, the patches are:
> 
> Reviewed-by: Tom Stellard <thomas.stellard at amd.com>

Thanks, I managed to enable basic lit testing after all, see the
attached patches 4 and 5.


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-R600-SI-Add-pattern-for-the-AMDGPU.barrier.local-int.patch
Type: text/x-patch
Size: 1335 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130710/6950247b/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-R600-SI-Initial-local-memory-support.patch
Type: text/x-patch
Size: 13227 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130710/6950247b/attachment-0003.bin>


More information about the mesa-dev mailing list