[Mesa-dev] [PATCH RFC 3/3] glsl: Rework builtin_variables.cpp to reduce code duplication.

[Paul Berry]

On 11 July 2013 12:06, Matt Turner <mattst88 at gmail.com> wrote:

> On Mon, Jul 8, 2013 at 10:40 AM, Paul Berry <stereotype441 at gmail.com>
> wrote:
> > +   const glsl_type *typ(const char *name)
>
> This must not be a typo, since it's consistent.
>

Heh, "type" is a reserved word in so many languages that I guess I assumed
it was reserved in C++ without even checking.  Turns out it isn't.

I'm doing a minor re-spin of this patch to address Ian's comments; I'll
rename it to "type" in v2.


>
> The series is Reviewed-by: Matt Turner <mattst88 at gmail.com>
>
> with the caveat that the third patch is hard to review and I could
> easily have missed something, since it's nearly a total rewrite. But
> there's no question that the final result is better. Thanks for doing
> this clean up.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130712/a92bbeb6/attachment.html>