[Mesa-dev] [PATCH v2 1/5] glsl: Rework builtin_variables.cpp to reduce code duplication.

[Kenneth Graunke]

On 07/12/2013 06:25 PM, Paul Berry wrote:
> So this patch reworks things so that instead of having a separate
> function for each shader type and GLSL version, we have a function for
> constants, one for uniforms, one for varyings, and one for the special
> variables that are specific to each shader type.

Brilliant.  Series is:

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Like Ian, I'm not super crazy about the local type variables, just to 
fix whitespace issues - I'd almost rather just go over the 80 character 
limit.  I gave up on meeting that requirement for the built-in type 
code, since I felt it was more readable to keep things on one line.

But, I don't really care that much, so whatever you like.